Update functionMap.php to fix return types and parameters #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the signatures for the following functions : apcu_cache_info apcu_sma_info strval
|
Don't change the strval signature, it's actually correct. To find out why, search the issue tracker. |
staabm
reviewed
Dec 12, 2024
resources/functionMap.php
Outdated
| @@ -12088,7 +12088,7 @@ | |||
| 'strtoupper' => ['uppercase-string', 'str'=>'string'], | |||
| 'strtr' => ['string', 'str'=>'string', 'from'=>'string', 'to'=>'string'], | |||
| 'strtr\'1' => ['string', 'str'=>'string', 'replace_pairs'=>'array'], | |||
| 'strval' => ['string', 'var'=>'__stringAndStringable|int|float|bool|resource|null'], | |||
| 'strval' => ['string', 'var'=>'mixed'], | |||
There was a problem hiding this comment.
I think it was correct before, see e.g. phpstan/phpstan#9295 (comment)
There was a problem hiding this comment.
Ok, so the PHP documentation is incorrect, next time I will check the issue tracker first.
I have reverted and commit it again.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for phpstan/phpstan#12148 (comment)
Fixing the signatures for the following functions :
apcu_cache_info()
apcu_sma_info()
And another one
strval()
setting the parameter value to mixed as defined https://www.php.net/manual/en/function.strval.php
Code snippet that reproduces the problem :
https://phpstan.org/r/f3e4b8de-f919-44d2-8b08-b979c5240693