Respect asserts and throws on pure functions that return void #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-worman
force-pushed
the
Assert-and-throws-are-side-effects
branch
from
bde30fc to
1fd854f
Compare
jack-worman
changed the title
|
This pull request has been marked as ready for review. |
jack-worman
force-pushed
the
Assert-and-throws-are-side-effects
branch
from
1fd854f to
5335a05
Compare
jack-worman
force-pushed
the
Assert-and-throws-are-side-effects
branch
from
5335a05 to
8af8b0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of the problems from phpstan/phpstan#12224
This should now be fixed: https://phpstan.org/r/852dd5b6-e76c-41ed-a0fb-7b1a46b0900f