Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add-fpow #3718

Closed
wants to merge 1 commit into from
Closed

Add-fpow #3718

wants to merge 1 commit into from

Conversation

jack-worman
Copy link
Contributor

@jack-worman jack-worman commented Dec 10, 2024 •
edited
Loading

@ondrejmirtes
Copy link
Member

This doesn't solve the problem. PHPStan already knows about the function. See phpstan/phpstan#12226 (comment)

@jack-worman
Copy link
Contributor Author

jack-worman commented Dec 10, 2024 •
edited
Loading

This doesn't solve the problem. PHPStan already knows about the function. See phpstan/phpstan#12226 (comment)

Although it may not solve the problem, shouldn't fpow() still be added? Why is mb_ucfirst() added to the new list?

@ondrejmirtes
Copy link
Member

Not sure, we don't need it there.

@jack-worman
Copy link
Contributor Author

Not sure, we don't need it there.

To help my understanding, could you give me an example of a reason to ever add a function to this file?

@ondrejmirtes
Copy link
Member

  1. If it exists on PHP 7 (php-8-stubs are used for PHP 8+)
  2. Or if we want to type more specific parameter or return types

@jack-worman jack-worman deleted the Add-fpow branch December 12, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jack-worman @ondrejmirtes