Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native PHPDocs for Rule and RuleTestCase #3698

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

paulbalandan
Copy link
Contributor

I'm using intelephense in VS Code and it cannot understand the @phpstan- annotated PHPDocs. However, it understands the native PHPDocs, including the generics related. This PR uses those PHPDocs for Rule and RuleTestCase for better IDE completion on vscode.

Proof:
image

@ondrejmirtes ondrejmirtes merged commit fba167c into phpstan:1.12.x Dec 10, 2024
453 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@paulbalandan paulbalandan deleted the native-phpdoc-rule branch December 10, 2024 12:55
@paulbalandan
Copy link
Contributor Author

Thanks for merging this. Would you be ok for follow up PRs that (1) removes similar @phpstan- annotated PHPDocs and replaces them with the native ones, and (2) removes superfluous PHPDocs due to better IDE completions, especially in the rules?

@ondrejmirtes
Copy link
Member

We need to acknowledge this isn't fixing anything in PHPStan, but rather addressing a shortcoming of another tool, but I'm okay with this, we don't need any prefixes in PHPDocs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants