Fix for endless loop detection
#3621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favor of adding this to 1.12.x in #3622 after reading that 1.12.x will still receive support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this in the generalized finalScope which includes an already filtered bodyScope is too late and causes false-positives.
Fixes phpstan/phpstan#11992
Improves endless loop detection as in cases like phpstan/phpstan#736
And most likely it fixes what was mentioned in the discussion phpstan/phpstan#11986 too
Follow-up for #3573
Alternative for 1.12.x in case this is too annoying for users there and needs another release...: #3622