-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stub for openssl_sign() function #3532
base: 1.12.x
Are you sure you want to change the base?
Conversation
You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x. |
Will rebase properly in a minute |
…re` variable type which is now shown as `mixed` instead of `string`. Fixes phpstan/phpstan#11791
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to register this stub file in config/config.neon.
@ondrejmirtes Added it to conf/config.neon |
Do I need to type all arguments or just this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix proc_open() from phpstan/phpstan#11777 too.
Copy the PHPdoc from jetbrains/phpstorm-stubs and leave out unimportant stuff like description. |
@ondrejmirtes I've updated phpdoc. Let me know if I need to do something more. Thanks |
@ondrejmirtes I think there is some bug in PHP manual of this
In description of input params, there is no mention of |
Made bug report for php docs php/doc-en#3829 |
Also signature changed in PHP 8 so I should probably create two stub files right? Something like |
Okay asked about this |
Adding openssl_sign() stub so PHPStan will correctly deduce
$signature
variable type which is now shown asmixed
instead ofstring
.Fixes phpstan/phpstan#11791