Report precise offsets in errors #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x. |
ondrejmirtes
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Some CS violations here https://github.com/phpstan/phpstan-src/actions/runs/11069234135/job/30756357522
ruudk
force-pushed
the
v2-precise-offset
branch
2 times, most recently
from
15139f4 to
09a22e8
Compare
|
Fixed! 💡 TIL: |
|
I believe the 71 failing tests are unrelated to my change. Is that correct? |
|
I'm wondering. Shouldn't we also port this to 1.12 under bleeding edge? You say that 1.12 + bleeding edge == 2.0, right? |
ruudk
force-pushed
the
v2-precise-offset
branch
from
09a22e8 to
1650518
Compare
|
2.0 is close enough :) |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#11760