Add PhpVersion param on isSmallerThanOrEqual and isGreaterThanOrEqual

[VincentLanglet]

As recommended in phpstan/phpstan#11732 (comment)

I'll do the implementation/fix in another PR, to be sure to not delay the signature update.

[phpstan-bot]

You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x.

[ondrejmirtes]

Also other potential methods to add it to:

• getSmallerType
• getSmallerOrEqualType
• getGreaterType
• getGreaterOrEqualType

[ondrejmirtes]

What about here?

[VincentLanglet]

Indeed, var_dump('' < 0); is true on PHP 8 but false on PHP 7.4

[ondrejmirtes]

What about here?

[ondrejmirtes]

Mention it in UPGRADING.md in minor breaks section at the bottom. Thanks!

[staabm]

I think we need a similar PR for methods which currently use PhpVersionStaticAccessor::getInstance() instead of using a PhpVersion parameter explicitly?

[ondrejmirtes]

That would be awesome!

[VincentLanglet]

I think we need a similar PR for methods which currently use PhpVersionStaticAccessor::getInstance() instead of using a PhpVersion parameter explicitly?

It's used by

• StubValidator => seems easy to change
• ConstantArrayType::findTypeAndMethodNames => Need to pass phpVersion to isCallable and getCallableParametersAcceptors
• ConstantStringType::isCallable

Changing the signature of isCallable seems to have a bigger impact since it's used in

• Type::inferTemplateTypes
• Type::isSubTypeOf
• Type::isSuperTypeOf
• Type::acceptsWithReason
• Type::traverseSimultaneously

And changing those signature lead to too many changes...

[ondrejmirtes]

Yeah, I wouldn't want to do this for Type::isCallable() / ConstantArrayType::findTypeAndMethodNames. It's just covering a quirk/edge-case of pre-PHP 8.0 behaviour.

[ondrejmirtes]

Thank you.