Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow toggling treatPhpDocTypesAsCertain tip #3452

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Sep 18, 2024

@phpstan-bot
Copy link
Collaborator

You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x.

@ruudk ruudk changed the base branch from 2.0.x to 1.12.x September 18, 2024 12:15
@ruudk ruudk force-pushed the toggle-treatPhpDocTypesAsCertain branch from 0d41890 to 1d0e5ff Compare September 18, 2024 12:15
@ondrejmirtes ondrejmirtes merged commit 5582803 into phpstan:1.12.x Sep 19, 2024
476 of 499 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@ruudk ruudk deleted the toggle-treatPhpDocTypesAsCertain branch September 19, 2024 07:20
@ondrejmirtes
Copy link
Member

  1. This would be nice to have documented at https://phpstan.org/config-reference
  2. There's a rule in phpstan-strict-rules that would also benefit from this toggle :)

@ruudk
Copy link
Contributor Author

ruudk commented Sep 19, 2024

ondrejmirtes pushed a commit to phpstan/phpstan-strict-rules that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not suggest to turn off treatPhpDocTypesAsCertain when it's enabled explicitly
3 participants