Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the stricter signatures for php 8.0 after the basic ones #3259

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

thg2k
Copy link
Contributor

@thg2k thg2k commented Jul 22, 2024

This change is required to make the stricter map effective.

@staabm
Copy link
Contributor

staabm commented Jul 22, 2024

do you have a failling test-case about the bug you try to fix?

looking at e.g. thg2k@f46e470 looks like the resources/functionMap_php80delta_bleedingEdge.php works and overrides signatures from resources/functionMap_bleedingEdge.php

@thg2k
Copy link
Contributor Author

thg2k commented Jul 22, 2024

do you have a failling test-case about the bug you try to fix?

looking at e.g. thg2k@f46e470 looks like the resources/functionMap_php80delta_bleedingEdge.php works and overrides signatures from resources/functionMap_bleedingEdge.php

That's because error_log does not appear in the previous deltas, otherwise first the signature is loaded from the functionMap_php80delta_bleedingEdge.php file and then overwritten by the functionMap_php80delta.php. In this case, error_log does not appear there.

I noticed because imagecreatetruecolor is overridden on both files, resulting in the wrong signatures with bleeding edge enabled.

@ondrejmirtes ondrejmirtes merged commit 4a0ffab into phpstan:1.11.x Jul 23, 2024
445 of 454 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@thg2k thg2k deleted the pr/strict80 branch July 23, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants