Ignore non-explicit NEVER in purity check #3243
Conversation
staabm
changed the title
src/Analyser/NodeScopeResolver.php
Outdated
| if ($exprType->isCallable()->yes()) { | ||
| if ( | ||
| $exprType->isCallable()->yes() | ||
| && (!$exprType instanceof NeverType || $exprType->isExplicit()) |
There was a problem hiding this comment.
a different way to fix this would be to make NeverType return a different acceptor on getCallableParametersAcceptors when non-explicit
There was a problem hiding this comment.
Yeah, that would make more sense to me. It's basically never going to be called so a special class instead of TrivialParametersAcceptor would be welcome. It's pure, and probably also returns NeverType?
src/Analyser/NodeScopeResolver.php
Outdated
| if ($exprType->isCallable()->yes()) { | ||
| if ( | ||
| $exprType->isCallable()->yes() | ||
| && (!$exprType instanceof NeverType || $exprType->isExplicit()) |
There was a problem hiding this comment.
Yeah, that would make more sense to me. It's basically never going to be called so a special class instead of TrivialParametersAcceptor would be welcome. It's pure, and probably also returns NeverType?
|
Well, or NeverType doesn't have to return yes for isCallable, I'm not sure why it does. |
|
This pull request has been marked as ready for review. |
| public function testBug11207b(): void | ||
| { | ||
| $this->treatPhpDocTypesAsCertain = true; | ||
| $this->analyse([__DIR__ . '/data/bug-11207.php'], []); |
There was a problem hiding this comment.
This kind of pattern is usually done via a dataProvider.
|
Thank you. |
closes phpstan/phpstan#11207