Improved sprintf() inference #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jul 13, 2024
Comment on lines
+49
to
+56
| $s = sprintf('%20s', 'abc'); | ||
| assertType("' abc'", $s); | ||
|
|
||
| $s = sprintf('%20s', true); | ||
| assertType("' 1'", $s); | ||
|
|
||
| $s = sprintf('%20s', returnsBool()); | ||
| assertType("non-falsy-string", $s); |
There was a problem hiding this comment.
regressions from #3167 which made sprintf 1:1 return constant values from arguments (bypassing sprintf formatting rules)
staabm
commented
Jul 13, 2024
Comment on lines
+55
to
+58
| assertType('non-falsy-string&numeric-string', sprintf('%2$14s', $mixed, $posInt)); | ||
| assertType('non-falsy-string&numeric-string', sprintf('%2$14s', $mixed, $negInt)); |
There was a problem hiding this comment.
improvements because of the added toString() handling
|
This pull request has been marked as ready for review. |
staabm
commented
Jul 13, 2024
| @@ -115,19 +119,19 @@ public function getTypeFromFunctionCall( | |||
| $returnType = new StringType(); | |||
| } | |||
|
|
|||
| return $this->getConstantType($args, $returnType, $functionReflection, $scope); | |||
There was a problem hiding this comment.
instead of building the general return type first and pass it as a default-return into getConstantType() we now invoke getConstantType() first and build the general return type only if we were not able to infer a constant type in the first place
|
This pull request has been marked as ready for review. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another small improvement while thinking thru more details of #3192
it fixes a bug regressed with #3167