Improve the return type of array_map() for constant arrays #3156
Conversation
| assertType("array{'0', '1'}", array_map(strval(...), $a)); | ||
| assertType("array{'0', '1'}", array_map(str(...), $a)); | ||
| assertType("array{'0'|'1', '0'|'1'}", array_map(fn ($v) => strval($v), $a)); | ||
| assertType("array{'0'|'1', '0'|'1'}", array_map(fn ($v) => (string)$v, $a)); |
There was a problem hiding this comment.
The ClosureType::$returnType is bound to the union of the other elements of the array with the type of the callback. I'm looking for a way to get around that.
| $callback = new Name($callName); | ||
| } elseif ($callback instanceof FuncCall && $callback->isFirstClassCallable() && | ||
| $callback->getAttribute('phpstan_cache_printer') !== null && | ||
| preg_match('/\A(?<name>\\\\?[^()]+)\(...\)\z/', $callback->getAttribute('phpstan_cache_printer'), $m) === 1 |
There was a problem hiding this comment.
To avoid binding the ClosureType::$returnType to a union with the results of other elements, I have replaced it with a direct call to the original function. I don't want to misuse the phpstan_cache_printer attribute, but there doesn't seem to be any other suitable source of the original function.
|
|
||
| if ($callableType->isCallable()->yes()) { | ||
| $valueTypes = [new NeverType()]; | ||
| foreach ($callableType->getCallableParametersAcceptors($scope) as $parametersAcceptor) { | ||
| $valueTypes[] = $parametersAcceptor->getReturnType(); | ||
| } | ||
| $valueType = TypeCombinator::union(...$valueTypes); | ||
| $callback = $functionCall->getArgs()[0]->value; | ||
| if ($callback instanceof String_) { |
There was a problem hiding this comment.
This entire code block isn't the right solution. You don't need to do any of that. You should be able to achieve the same thing with just:
$callback = $functionCall->getArgs()[0]->value;
$callbackReturnType = $scope->getType(new FuncCall($callback, [
new Arg(new TypeExpr($constantArray->getValueTypes()[$i])),
]));If that doesn't work for some expressions, then the root cause is elsewhere.
zonuexe
force-pushed
the
feature/improve-array_map-type
branch
from
b5cae3f to
31ae118
Compare
zonuexe
force-pushed
the
feature/improve-array_map-type
branch
from
31ae118 to
b2dae42
Compare
resolve phpstan/phpstan#11180