DateTimeImmutable::modify() can no longer return false since PHP 8.3 #3094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanTvrdik
force-pushed
the
patch-1
branch
3 times, most recently
from
5867da6 to
bfc036f
Compare
|
Some tests failed, otherwise 👍 Btw what about |
It throws |
|
There would have to be conditionally loaded stub file for 8.4+. |
|
Can we fix |
|
I feel like fixing the return type and adding |
|
Looks to be fixed as part of #3209. |
|
I totally forgot about this PR, sorry! I was forced to fix this as part of update to jetbrains/phpstorm-stubs about exception-throwing on 8.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 8.3,
DateTimeImmutable::modify()can no longer returnfalse, and throwsDateMalformedStringExceptioninstead.Relevant RFC: https://wiki.php.net/rfc/datetime-exceptions
Relevant php-src commit: php/php-src@b7860cd
Relevant code change: