Check types when argument is passed by reference #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons and methods. Initially, all pass by reference parameters were skipped for type checking. This change continues to skip those checks for builtin PHP methods, but does check parameters for userland methods.
ondrejmirtes
changed the title
ondrejmirtes
requested changes
Feb 24, 2024
| @@ -0,0 +1,17 @@ | |||
| <?php | |||
|
|
|||
| namespace PassedByReference; | |||
There was a problem hiding this comment.
This needs to have "Bug10626" namespace
| @@ -0,0 +1,27 @@ | |||
| <?php | |||
|
|
|||
| class VerifyLoginTask{ | |||
There was a problem hiding this comment.
This needs to have Bug8296 namespace
ondrejmirtes
approved these changes
Feb 24, 2024
|
Thank you! |
This was referenced Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do type checks on pass by reference parameters for non-builtin functions and methods.
Initially, all pass by reference parameters were skipped for type checking. This change continues to skip those checks for builtin PHP methods, but does check parameters for userland methods.