-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DynamicFunctionReturnTypeExtension for the get_debug_type function. #2910
Conversation
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
61be403
to
1e360f4
Compare
Looking at the failing checks, none of them seem to be genuinely caused by this change. |
1e360f4
to
8c972b6
Compare
Please add a pattern-matching example-test and use it in rule-tests which emit errors before this PR and are expected to be fixed now |
Updated the PR. Error emitted before this PR: |
17d6626
to
4c1b0cb
Compare
Conditional type specifier for `get_debug_type` function.
4c1b0cb
to
d5dc25f
Compare
Updated to also specify the type in condition branches. This closes phpstan/phpstan#10585 for me. I have a question about
Is this expected? Can this be turned off? Are those considered equivalent? |
Thank you! |
Closes: phpstan/phpstan#10558
Closes: phpstan/phpstan#10585