Fix bug parsing negative classes containing only digits ([^0-9])

phpstan · Jul 19, 2024 · fc75deb · fc75deb
1 parent dbb9665
commit fc75deb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/Type/Php/RegexArrayShapeMatcher.php b/src/Type/Php/RegexArrayShapeMatcher.php
@@ -625,6 +625,13 @@ private function walkGroupAst(TreeNode $ast, TrinaryLogic &$isNonEmpty, TrinaryL
 			}
 		}
 
+		// [^0-9] should not parse as numeric-string, and [^list-everything-but-numbers] is technically
+		// doable but really silly compared to just \d so we can safely assume the string is not numeric
+		// for negative classes
+		if ($ast->getId() === '#negativeclass') {
+			$isNumeric = TrinaryLogic::createNo();
+		}
+
 		foreach ($children as $child) {
 			$this->walkGroupAst(
 				$child,

diff --git a/tests/PHPStan/Analyser/nsrt/preg_match_shapes.php b/tests/PHPStan/Analyser/nsrt/preg_match_shapes.php
@@ -515,4 +515,7 @@ function bug11323(string $s): void {
 	if (preg_match('{(x?([1-4])\d)}', $s, $matches)) {
 		assertType('array{string, non-empty-string, numeric-string}', $matches);
 	}
+	if (preg_match('{([^1-4])}', $s, $matches)) {
+		assertType('array{string, non-empty-string}', $matches);
+	}
 }