Improve pure method detection and mark Redis::get explicitly impure

Refs #10215
phpstan · Nov 29, 2023 · f9e5efa · f9e5efa
1 parent 093bbb2
commit f9e5efa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/bin/functionMetadata_original.php b/bin/functionMetadata_original.php
@@ -153,6 +153,8 @@
 	'DateTimeImmutable::getTimestamp' => ['hasSideEffects' => false],
 	'DateTimeImmutable::getTimezone' => ['hasSideEffects' => false],
 
+	'Redis::get' => ['hasSideEffects' => true],
+
 	'XmlReader::next' => ['hasSideEffects' => true],
 	'XmlReader::read' => ['hasSideEffects' => true],
 ];
diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -35,10 +35,12 @@
 use PHPStan\Type\VoidType;
 use ReflectionException;
 use function array_map;
+use function count;
 use function explode;
 use function filemtime;
 use function in_array;
 use function is_bool;
+use function preg_match;
 use function sprintf;
 use function strtolower;
 use function time;
@@ -429,6 +431,9 @@ public function hasSideEffects(): TrinaryLogic
 		if ($this->isPure !== null) {
 			return TrinaryLogic::createFromBoolean(!$this->isPure);
 		}
+		if (count($this->getParameters()) === 0 && preg_match('#^(get|is|has|can)[A-Z0-9_]#', $this->getName())) {
+			return TrinaryLogic::createNo();
+		}
 
 		return TrinaryLogic::createMaybe();
 	}