RegexArrayShapeMatcher: fix regex wildcard omitted from type

phpstan · Dec 11, 2024 · e9e419c · e9e419c
1 parent 4d3a9ab
commit e9e419c
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 5 deletions.
diff --git a/src/Type/Regex/RegexGroupParser.php b/src/Type/Regex/RegexGroupParser.php
@@ -535,13 +535,19 @@ private function getLiteralValue(TreeNode $node, ?array &$onlyLiterals, bool $ap
 			if (
 				$appendLiterals
 				&& $onlyLiterals !== null
-				&& (!in_array($value, ['.'], true) || $isEscaped || $inCharacterClass)
 			) {
-				if ($onlyLiterals === []) {
-					$onlyLiterals = [$value];
+				if (
+					in_array($value, ['.'], true)
+					&& !($isEscaped || $inCharacterClass)
+				) {
+					$onlyLiterals = null;
 				} else {
-					foreach ($onlyLiterals as &$literal) {
-						$literal .= $value;
+					if ($onlyLiterals === []) {
+						$onlyLiterals = [$value];
+					} else {
+						foreach ($onlyLiterals as &$literal) {
+							$literal .= $value;
+						}
 					}
 				}
 			}

diff --git a/tests/PHPStan/Analyser/nsrt/bug-12211.php b/tests/PHPStan/Analyser/nsrt/bug-12211.php
@@ -0,0 +1,16 @@
+<?php // lint >= 7.4
+
+declare(strict_types = 1);
+
+namespace Bug12211;
+
+use function PHPStan\Testing\assertType;
+
+const REGEX = '((m.x))';
+
+function foo(string $text): void {
+	assert(preg_match(REGEX, $text, $match) === 1);
+	assertType('array{string, non-falsy-string}', $match);
+}
+
+