Fix range()

phpstan · May 15, 2024 · cb0cd1c · cb0cd1c
1 parent 35ff689
commit cb0cd1c
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/Type/Php/RangeFunctionReturnTypeExtension.php b/src/Type/Php/RangeFunctionReturnTypeExtension.php
@@ -22,7 +22,7 @@
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\UnionType;
-use function abs;
+use ValueError;
 use function count;
 use function range;
 
@@ -66,12 +66,11 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 						continue;
 					}
 
-					$rangeSpanned = abs($endConstant->getValue() - $startConstant->getValue());
-					if ($rangeSpanned <= $stepConstant->getValue()) {
+					try {
+						$rangeValues = range($startConstant->getValue(), $endConstant->getValue(), $stepConstant->getValue());
+					} catch (ValueError) {
 						continue;
 					}
-
-					$rangeValues = range($startConstant->getValue(), $endConstant->getValue(), $stepConstant->getValue());
 					if (count($rangeValues) > self::RANGE_LENGTH_THRESHOLD) {
 						if ($startConstant instanceof ConstantIntegerType && $endConstant instanceof ConstantIntegerType) {
 							if ($startConstant->getValue() > $endConstant->getValue()) {