fix phpstan

phpstan · Jun 21, 2024 · c073c6a · c073c6a
1 parent 891a631
commit c073c6a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/Testing/TypeInferenceTestCase.php b/src/Testing/TypeInferenceTestCase.php
@@ -18,12 +18,14 @@
 use PHPStan\Reflection\InitializerExprTypeResolver;
 use PHPStan\Reflection\SignatureMap\SignatureMapProvider;
 use PHPStan\Rules\Properties\ReadWritePropertiesExtensionProvider;
+use PHPStan\ShouldNotHappenException;
 use PHPStan\TrinaryLogic;
 use PHPStan\Type\ConstantScalarType;
 use PHPStan\Type\FileTypeMapper;
 use PHPStan\Type\Type;
 use PHPStan\Type\VerbosityLevel;
 use Symfony\Component\Finder\Finder;
+use function array_key_exists;
 use function array_map;
 use function array_merge;
 use function count;
@@ -302,6 +304,9 @@ private static function isFileLintSkipped(string $file): bool
 			@fclose($f);
 
 			if (preg_match('~<?php\\s*\\/\\/\s*lint\s*([^\d\s]+)\s*([^\s]+)\s*~i', $firstLine, $m) === 1) {
+				if (!array_key_exists(1, $m) || !array_key_exists(2, $m)) {
+					throw new ShouldNotHappenException();
+				}
 				return version_compare(PHP_VERSION, $m[2], $m[1]) === false;
 			}
 		}

diff --git a/src/Type/Php/SprintfFunctionDynamicReturnTypeExtension.php b/src/Type/Php/SprintfFunctionDynamicReturnTypeExtension.php
@@ -7,6 +7,7 @@
 use PHPStan\Internal\CombinationsHelper;
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Reflection\InitializerExprTypeResolver;
+use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\Accessory\AccessoryNonEmptyStringType;
 use PHPStan\Type\Accessory\AccessoryNonFalsyStringType;
 use PHPStan\Type\Accessory\AccessoryNumericStringType;
@@ -73,6 +74,10 @@ public function getTypeFromFunctionCall(
 					// of stringy type, then the return value will be of the same type
 					$checkArgType = $scope->getType($args[$checkArg]->value);
 
+					if (!array_key_exists(2, $matches)) {
+						throw new ShouldNotHappenException();
+					}
+
 					if ($matches[2] === 's' && $checkArgType->isString()->yes()) {
 						$singlePlaceholderEarlyReturn = $checkArgType;
 					} elseif ($matches[2] !== 's') {