OptimizedSingleFileSourceLocator::locateIdentifiersByType() - support…

… constants
phpstan · Oct 26, 2022 · 9914301 · 9914301
1 parent 3961f7c
commit 9914301
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 1 deletion.
diff --git a/src/Reflection/BetterReflection/SourceLocator/OptimizedSingleFileSourceLocator.php b/src/Reflection/BetterReflection/SourceLocator/OptimizedSingleFileSourceLocator.php
@@ -210,6 +210,50 @@ public function locateIdentifiersByType(Reflector $reflector, IdentifierType $id
 			}
 		}
 
+		if ($identifierType->isConstant()) {
+			$constantNodes = $fetchedNodesResult->getConstantNodes();
+			foreach ($constantNodes as $constantNodesArray) {
+				foreach ($constantNodesArray as $fetchedConstantNode) {
+					$constantNode = $fetchedConstantNode->getNode();
+
+					if ($constantNode instanceof Const_) {
+						foreach ($constantNode->consts as $constPosition => $const) {
+							if ($const->namespacedName === null) {
+								throw new ShouldNotHappenException();
+							}
+
+							$constantReflection = $nodeToReflection->__invoke(
+								$reflector,
+								$constantNode,
+								$fetchedConstantNode->getLocatedSource(),
+								$fetchedConstantNode->getNamespace(),
+								$constPosition,
+							);
+							if (!$constantReflection instanceof ReflectionConstant) {
+								throw new ShouldNotHappenException();
+							}
+
+							$reflections[] = $constantReflection;
+						}
+
+						continue;
+					}
+
+					$constantReflection = $nodeToReflection->__invoke(
+						$reflector,
+						$constantNode,
+						$fetchedConstantNode->getLocatedSource(),
+						$fetchedConstantNode->getNamespace(),
+					);
+					if (!$constantReflection instanceof ReflectionConstant) {
+						throw new ShouldNotHappenException();
+					}
+
+					$reflections[] = $constantReflection;
+				}
+			}
+		}
+
 		return $reflections;
 	}
 

diff --git a/...HPStan/Reflection/BetterReflection/SourceLocator/OptimizedSingleFileSourceLocatorTest.php b/...HPStan/Reflection/BetterReflection/SourceLocator/OptimizedSingleFileSourceLocatorTest.php
@@ -101,7 +101,13 @@ public function dataForIdenifiersByType(): iterable
 			],
 			'constants' => [
 				new IdentifierType(IdentifierType::IDENTIFIER_CONSTANT),
-				[],
+				[
+					'ANOTHER_NAME',
+					'ConstFile\ANOTHER_NAME',
+					'ConstFile\TABLE_NAME',
+					'OPTIMIZED_SFSL_OBJECT_CONSTANT',
+					'const_with_dir_const',
+				],
 				__DIR__ . '/data/const.php',
 			],
 		];