Merge branch refs/heads/1.10.x into 1.11.x

src/Testing/RuleTestCase.php

@@ -97,7 +97,7 @@ private function getAnalyser(): Analyser
 				$this->shouldPolluteScopeWithAlwaysIterableForeach(),
 				[],
 				[],
-				true,
+				self::getContainer()->getParameter('exceptions')['implicitThrows'],
 				$this->shouldTreatPhpDocTypesAsCertain(),
 				self::getContainer()->getParameter('featureToggles')['detectDeadTypeInMultiCatch'],
 			);

tests/PHPStan/Rules/Exceptions/AbilityToDisableImplicitThrowsTest.php

@@ -0,0 +1,38 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Exceptions;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use function array_merge;
+
+/**
+ * @extends RuleTestCase<CatchWithUnthrownExceptionRule>
+ */
+class AbilityToDisableImplicitThrowsTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new CatchWithUnthrownExceptionRule();
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/ability-to-disable-implicit-throws.php'], [
+			[
+				'Dead catch - Throwable is never thrown in the try block.',
+				17,
+			],
+		]);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return array_merge(
+			parent::getAdditionalConfigFiles(),
+			[__DIR__ . '/data/ability-to-disable-implicit-throws.neon'],
+		);
+	}
+
+}

tests/PHPStan/Rules/Exceptions/data/ability-to-disable-implicit-throws.neon

@@ -0,0 +1,3 @@
+parameters:
+    exceptions:
+        implicitThrows: false

tests/PHPStan/Rules/Exceptions/data/ability-to-disable-implicit-throws.php

@@ -0,0 +1,25 @@
+<?php declare(strict_types = 1);
+
+namespace AbilityToDisableImplicitThrows;
+
+class HelloWorld
+{
+	public function sayHello(callable $c): void
+	{
+		try {
+			$c();
+		} catch (\Throwable $e) { // no error here
+
+		}
+
+		try {
+			$this->method();
+		} catch (\Throwable $e) { // Dead catch - Throwable is never thrown in the try block.
+
+		}
+	}
+
+	public function method(): void
+	{
+	}
+}