fix cleanup loop

phpstan · Dec 26, 2024 · 8cb3030 · 8cb3030
1 parent 9c1a389
commit 8cb3030
Showing 1 changed file with 15 additions and 8 deletions.
diff --git a/src/Type/Php/PregSplitDynamicReturnTypeExtension.php b/src/Type/Php/PregSplitDynamicReturnTypeExtension.php
@@ -68,20 +68,33 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 			return new ErrorType();
 		}
 
+		$limits = [];
 		if ($limitArg === null) {
 			$limits = [-1];
 		} else {
 			$limitType = $scope->getType($limitArg->value);
-			$limits = $limitType->getConstantScalarValues();
+			foreach ($limitType->getConstantScalarValues() as $limit) {
+				if (!is_int($limit)) {
+					return new ErrorType();
+				}
+				$limits[] = $limit;
+			}
 		}
 
+		$flags = [];
 		if ($flagArg === null) {
 			$flags = [0];
 		} else {
 			$flagType = $scope->getType($flagArg->value);
-			$flags = $flagType->getConstantScalarValues();
+			foreach ($flagType->getConstantScalarValues() as $flag) {
+				if (!is_int($flag)) {
+					return new ErrorType();
+				}
+				$flags[] = $flag;
+			}
 		}
 
+
 		if (count($patternConstantTypes) === 0 || count($subjectConstantTypes) === 0) {
 			$returnNonEmptyStrings = $flagArg !== null && $this->bitwiseFlagAnalyser->bitwiseOrContainsConstant($flagArg->value, $scope, 'PREG_SPLIT_NO_EMPTY')->yes();
 			if ($returnNonEmptyStrings) {
@@ -136,13 +149,7 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 		foreach ($patternConstantTypes as $patternConstantType) {
 			foreach ($subjectConstantTypes as $subjectConstantType) {
 				foreach ($limits as $limit) {
-					if (!is_int($limit)) {
-						return null;
-					}
 					foreach ($flags as $flag) {
-						if (!is_int($flag)) {
-							return null;
-						}
 						$result = @preg_split($patternConstantType->getValue(), $subjectConstantType->getValue(), $limit, $flag);
 						if ($result === false) {
 							continue;