MethodCall with Expr name adds an implicit throw point

phpstan · Sep 13, 2021 · 84b0934 · 84b0934
1 parent 0b92888
commit 84b0934
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -1961,6 +1961,7 @@ function (MutatingScope $scope) use ($expr, $nodeCallback, $context): Expression
 			if ($expr->name instanceof Expr) {
 				$methodNameResult = $this->processExprNode($expr->name, $scope, $nodeCallback, $context->enterDeep());
 				$throwPoints = array_merge($throwPoints, $methodNameResult->getThrowPoints());
+				$throwPoints[] = ThrowPoint::createImplicit($scope, $expr);
 				$scope = $methodNameResult->getScope();
 			} else {
 				$calledOnType = $scope->getType($expr->var);

diff --git a/tests/PHPStan/Rules/Exceptions/data/unthrown-exception.php b/tests/PHPStan/Rules/Exceptions/data/unthrown-exception.php
@@ -534,4 +534,13 @@ public function doFoo(\Exception $e)
 		}
 	}
 
+	public function doBar(string $s)
+	{
+		try {
+			$this->{'doFoo' . $s}();
+		} catch (\InvalidArgumentException $e) {
+
+		}
+	}
+
 }