Fix ConstantArray loose comparison

phpstan · Dec 25, 2024 · 7a3f001 · 7a3f001
1 parent 9e3d1d3
commit 7a3f001
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Type/Constant/ConstantArrayType.php b/src/Type/Constant/ConstantArrayType.php
@@ -422,9 +422,14 @@ public function looseCompare(Type $type, PhpVersion $phpVersion): BooleanType
 			return new ConstantBooleanType(false);
 		}
 
-		if ($this->isIterableAtLeastOnce()->no() && count($type->getConstantScalarValues()) === 1) {
-			// @phpstan-ignore equal.invalid, equal.notAllowed
-			return new ConstantBooleanType($type->getConstantScalarValues()[0] == []); // phpcs:ignore
+		if ($this->isIterableAtLeastOnce()->no()) {
+			if (count($type->getConstantScalarValues()) === 1) {
+				// @phpstan-ignore equal.invalid, equal.notAllowed
+				return new ConstantBooleanType($type->getConstantScalarValues()[0] == []); // phpcs:ignore
+			}
+			if ($type->isIterableAtLeastOnce()->yes()) {
+				return new ConstantBooleanType(false);
+			}
 		}
 
 		return new BooleanType();

diff --git a/tests/PHPStan/Analyser/nsrt/loose-comparisons.php b/tests/PHPStan/Analyser/nsrt/loose-comparisons.php
@@ -761,7 +761,7 @@ public function sayIntersection(
 		assertType('false', $nonEmptyArr == $i);
 		assertType('false', $arr == $intRange);
 		assertType('false', $nonEmptyArr == $intRange);
-		assertType('bool', $emptyArr == $nonEmptyArr); // should be false
+		assertType('false', $emptyArr == $nonEmptyArr);
 		assertType('false', $nonEmptyArr == $emptyArr);
 		assertType('bool', $arr == $nonEmptyArr);
 		assertType('bool', $nonEmptyArr == $arr);