try fix for php 7.4

phpstan · Nov 25, 2024 · 48a48c8 · 48a48c8
1 parent bbdfcb4
commit 48a48c8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/Type/Php/SocketCreateReturnTypeExtension.php b/src/Type/Php/SocketCreateReturnTypeExtension.php
@@ -11,7 +11,6 @@
 use PHPStan\Type\ResourceType;
 use PHPStan\Type\Type;
 use PHPStan\Type\UnionType;
-use Socket;
 use function count;
 
 final class SocketCreateReturnTypeExtension implements DynamicFunctionReturnTypeExtension
@@ -29,7 +28,7 @@ public function getTypeFromFunctionCall(FunctionReflection $functionReflection,
 		}
 
 		if ($scope->getPhpVersion()->socketCreateUsesResource()->no()) {
-			return new UnionType([new ConstantBooleanType(false), new ObjectType(Socket::class)]);
+			return new UnionType([new ConstantBooleanType(false), new ObjectType('\\Socket')]);
 		}
 
 		if ($scope->getPhpVersion()->socketCreateUsesResource()->yes()) {

diff --git a/tests/PHPStan/Analyser/nsrt/socket-create.php b/tests/PHPStan/Analyser/nsrt/socket-create.php
@@ -12,8 +12,10 @@ public function sayHello(): void
 	{
 		if (PHP_VERSION_ID < 80000) {
 			assertType('resource|false', socket_create(AF_INET, SOCK_DGRAM, SOL_UDP));
-			return;
 		}
-		assertType('Socket|false', socket_create(AF_INET, SOCK_DGRAM, SOL_UDP));
+
+		if (PHP_VERSION_ID >= 80000) {
+			assertType('Socket|false', socket_create(AF_INET, SOCK_DGRAM, SOL_UDP));
+		}
 	}
 }