getimagesize, getimagesizefromstring zero is a possible value for hei…

…ght and width
phpstan · Jul 2, 2024 · 123e2ac · 123e2ac
1 parent e685c40
commit 123e2ac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/resources/functionMap.php b/resources/functionMap.php
@@ -3331,8 +3331,8 @@
 'gethostbyname' => ['string', 'hostname'=>'string'],
 'gethostbynamel' => ['list<string>|false', 'hostname'=>'string'],
 'gethostname' => ['string|false'],
-'getimagesize' => ['array{0: positive-int, 1: positive-int, 2: int, 3: string, mime: string, channels?: int, bits?: int}|false', 'imagefile'=>'string', '&w_info='=>'array'],
-'getimagesizefromstring' => ['array{0: positive-int, 1: positive-int, 2: int, 3: string, mime: string, channels?: int, bits?: int}|false', 'data'=>'string', '&w_info='=>'array'],
+'getimagesize' => ['array{0: 0|positive-int, 1: 0|positive-int, 2: int, 3: string, mime: string, channels?: int, bits?: int}|false', 'imagefile'=>'string', '&w_info='=>'array'],
+'getimagesizefromstring' => ['array{0: 0|positive-int, 1: 0|positive-int, 2: int, 3: string, mime: string, channels?: int, bits?: int}|false', 'data'=>'string', '&w_info='=>'array'],
 'getlastmod' => ['int|false'],
 'getmxrr' => ['bool', 'hostname'=>'string', '&w_mxhosts'=>'array', '&w_weight='=>'array'],
 'getmygid' => ['int|false'],

diff --git a/tests/PHPStan/Analyser/nsrt/image-size.php b/tests/PHPStan/Analyser/nsrt/image-size.php
@@ -14,8 +14,8 @@ function imageFoo(): void
 
 	list($width, $height, $type, $attr) = $imagesize;
 
-	assertType('int<1, max>', $width);
-	assertType('int<1, max>', $height);
+	assertType('int<0, max>', $width);
+	assertType('int<0, max>', $height);
 	assertType('int', $type);
 	assertType('string', $attr);
 	assertType('string', $imagesize['mime']);
@@ -31,8 +31,8 @@ function imagesizeFoo(string $s): void
 	}
 	list($width, $height, $type, $attr) = $imagesize;
 
-	assertType('int<1, max>', $width);
-	assertType('int<1, max>', $height);
+	assertType('int<0, max>', $width);
+	assertType('int<0, max>', $height);
 	assertType('int', $type);
 	assertType('string', $attr);
 	assertType('string', $imagesize['mime']);