Resolve PHP_INT_MAX as positive integer

phpstan · Sep 22, 2021 · 0cde73f · 0cde73f
1 parent be79bce
commit 0cde73f
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -1978,6 +1978,9 @@ private function resolveType(Expr $node): Type
 				if ($resolvedConstantName === '__COMPILER_HALT_OFFSET__') {
 					return new IntegerType();
 				}
+				if ($resolvedConstantName === 'PHP_INT_MAX') {
+					return IntegerRangeType::fromInterval(1, null);
+				}
 
 				$constantType = $this->reflectionProvider->getConstant($node->name, $this)->getValueType();
 

diff --git a/tests/PHPStan/Analyser/AnalyserIntegrationTest.php b/tests/PHPStan/Analyser/AnalyserIntegrationTest.php
@@ -447,6 +447,12 @@ public function testBug5639(): void
 		$this->assertCount(0, $errors);
 	}
 
+	public function testBug5657(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-5657.php');
+		$this->assertCount(0, $errors);
+	}
+
 	/**
 	 * @param string $file
 	 * @return \PHPStan\Analyser\Error[]

diff --git a/tests/PHPStan/Analyser/data/bug-5657.php b/tests/PHPStan/Analyser/data/bug-5657.php
@@ -0,0 +1,13 @@
+<?php
+
+namespace Bug5657;
+
+class HelloWorld
+{
+	/**
+	 * @param positive-int $totalParts
+	 */
+	public function sayHello(int $totalParts = PHP_INT_MAX): void
+	{
+	}
+}