Add rule to check @dataProvider

[villfa]

Here a new rule to check the @dataProvider annotation:

• does the method exist
• has the method the right case (depending on the checkFunctionNameCase parameter)
• is the method public
• is the method static

[staabm]

nice, thats something I had on my list for a few months :-).

the rule as is already provides a lot of value, so take my comment as an idea for further improvements - maybe in future PRs so we don't overcomplicate this very first iteration.

thanks!

[ondrejmirtes]

Almost perfect! :) Just a few points to change.

[ondrejmirtes]

Please use the newer regex.

And about deprecations - let's revisit this after this PR is merged and released 👍

[ondrejmirtes]

Thank you, it's perfect!

About the next steps: I'm thinking the deprecation should be reported by phpstan-phpunit when also phpstan-deprecation-rules are installed.

These steps need to be taken:

1. Introduce new deprecationRulesInstalled parameter in PHPStan core and set it to false.
2. Require phpstan/phpstan: ^1.9.3 in phpstan-deprecation-rules and set this parameter to true.
3. Require phpstan/phpstan: ^1.9.3 in phpstan-phpunit and use the deprecationRulesInstalled parameter to trigger the wanted behaviour.

Can you execute this plan? :) Thank you.

[villfa]

Can you execute this plan?

Sure :)

[ondrejmirtes]

Looks like PHPUnit 10 is going to also support attributes for dataProviders, can you please updste the rule so that it reads them too? Thanks!