Skip StringsMatchDynamicReturnTypeExtensionTest on PHP 7.2/7.3 #149
Conversation
ArrayShapeMatcher does not work for these old php versions
|
here we go |
| return; | ||
| } | ||
|
|
||
| yield from self::gatherAssertTypes(__DIR__ . '/data/strings-match.php'); |
There was a problem hiding this comment.
Can you please explain what is it about these example that they cannot work on PHP 7.2 and 7.3?
There was a problem hiding this comment.
The ArrayShapeMatcher requires named capturing groups to work
For the regex
There was a problem hiding this comment.
Can you link 3v4l.org example that shows different results for the cutoff versions? Something that's different between 7.3 and 7.4 and that makes this not work for these older versions.
I tried running the links in the comments but they have the same output https://3v4l.org/sOXbn https://3v4l.org/3SdDM
There was a problem hiding this comment.
See https://3v4l.org/dYdoO#v7.2.0
as soon as the hoa regex ast would contain enough information that we no longer need the caputring group hack, we could support 7.2/7.3
|
obsolete with phpstan/phpstan-src#3184 |
ArrayShapeMatcher does not work for these old php versions
should fix phpstan-src CI errors