Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stub for paginator #472

Closed
wants to merge 6 commits into from
Closed

add stub for paginator #472

wants to merge 6 commits into from

Conversation

84m
Copy link
Contributor

@84m 84m commented Sep 15, 2023

This makes the paginator aware of the type, when created from a query

@84m 84m marked this pull request as draft September 16, 2023 07:22
@84m
Copy link
Contributor Author

84m commented Sep 16, 2023

This is a follow-up to this discussion.

use IteratorAggregate;

/**
* @template T
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unlike the original this was changed to invariant because otherwise the return from getIterator() in l27 would throw a error

@84m 84m marked this pull request as ready for review September 16, 2023 08:25
@ondrejmirtes ondrejmirtes changed the base branch from 1.4.x to 1.3.x September 18, 2023 07:48
@ondrejmirtes
Copy link
Member

Merged as cba50e9, thank you.

@84m 84m deleted the make-paginator-type-aware-from-query branch September 18, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants