Skip to content

Commit

Permalink
Do not expect deprecation in test
Browse files Browse the repository at this point in the history
  • Loading branch information
ondrejmirtes committed Sep 6, 2024
1 parent d462eb9 commit 0f98bd1
Showing 1 changed file with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions tests/Type/Doctrine/Query/QueryResultTypeWalkerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public function setUp(): void
}

/** @dataProvider getTestData */
public function test(Type $expectedType, string $dql, ?string $expectedExceptionMessage = null, ?string $expectedDeprecationMessage = null): void
public function test(Type $expectedType, string $dql, ?string $expectedExceptionMessage = null): void
{
$em = self::$em;

Expand All @@ -210,9 +210,6 @@ public function test(Type $expectedType, string $dql, ?string $expectedException
if ($expectedExceptionMessage !== null) {
$this->expectException(Throwable::class);
$this->expectExceptionMessage($expectedExceptionMessage);
} elseif ($expectedDeprecationMessage !== null) {
$this->expectDeprecation();
$this->expectDeprecationMessage($expectedDeprecationMessage);
}

QueryResultTypeWalker::walk(
Expand Down Expand Up @@ -1548,17 +1545,6 @@ private function yieldConditionalDataset(): iterable
FROM QueryResult\Entities\Many m
',
null,
InstalledVersions::satisfies(new VersionParser(), 'doctrine/dbal', '>=3.4')
? null
: (
PHP_VERSION_ID >= 80100
? 'strpos(): Passing null to parameter #2 ($needle) of type string is deprecated'
: (
PHP_VERSION_ID < 80000
? 'strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior'
: null
)
),
];

$ormVersion = InstalledVersions::getVersion('doctrine/orm');
Expand Down

0 comments on commit 0f98bd1

Please sign in to comment.