Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #451: Raise minimum version of sebastian/comparator. #452

Merged
merged 3 commits into from
Dec 17, 2019
Merged

Issue #451: Raise minimum version of sebastian/comparator. #452

merged 3 commits into from
Dec 17, 2019

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Nov 29, 2019

@drupol drupol mentioned this pull request Nov 29, 2019
Closed
@ciaranmcnulty
Copy link
Member

Why is this not an issue in prophecy’s CI?

@drupol
Copy link
Contributor Author

drupol commented Nov 29, 2019

It does fail locally: https://pastebin.com/k5ZP4vpN

@drupol drupol mentioned this pull request Nov 29, 2019
Merged
@drupol
Copy link
Contributor Author

drupol commented Nov 29, 2019

See #453

@ciaranmcnulty
Copy link
Member

ok, I can't see any BC breaks in comparator 👍

Could we allow 2.x too?

@ciaranmcnulty ciaranmcnulty merged commit 65b55b2 into phpspec:master Dec 17, 2019
@ciaranmcnulty
Copy link
Member

I didn't realise that raising the phpspec version would drop out the old versions of PHP 🤦‍♂

Will revert in master

@drupol drupol mentioned this pull request Dec 17, 2019
Closed
16 tasks
@thewilkybarkid thewilkybarkid mentioned this pull request Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drupol @ciaranmcnulty