Change PRIVATE_FORMAT_PKCS8 to unique value to fix conflict with PUBL… #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Crypt\RSAclass there were two constants with the same value,PUBLIC_FORMAT_RAWandPRIVATE_FORMAT_PKCS8. This caused a bug in the_parseKey()method when$typewasPRIVATE_FORMAT_PKCS8because the value would match the first case statement as if it wasPUBLIC_FORMAT_RAWand it was unable to parse the key.I picked the value of
8because it was the next in series and was not already in use.Unit tests still pass for me so hopefully this is an easy PR to accept.