Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use triggered_by option for extensions argument for phpcs. Fixes #715. #716

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Use triggered_by option for extensions argument for phpcs. Fixes #715. #716

merged 2 commits into from
Jan 9, 2020

Conversation

hussainweb
Copy link
Contributor

@hussainweb hussainweb commented Dec 27, 2019

Q A
Branch master for features and deprecations
Bug fix? yes (missing phpcs functionality)
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets #715

I have given a detailed description in #715.

New Task Checklist:

  • Is the README.md file updated?
  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpspec tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

@hussainweb
Copy link
Contributor Author

CI is green. Several of those tasks are not relevant here given the nature and size of the problem. I have ticked them as well. I hope that's alright.

@veewee veewee added this to the 0.17.2 milestone Jan 9, 2020
@veewee veewee merged commit ca851d3 into phpro:master Jan 9, 2020
@veewee
Copy link
Contributor

veewee commented Jan 9, 2020

Thanks for the PR! Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants