Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support symfony 5, add support php74, drop support php71 #701

Merged
merged 4 commits into from
Nov 29, 2019

Conversation

veewee
Copy link
Contributor

@veewee veewee commented Nov 29, 2019

Q A
Branch master
Bug fix? yes
New feature? yes
BC breaks? yes
Deprecations? no
Documented? no
Fixed tickets

@veewee veewee added this to the 0.17.0 milestone Nov 29, 2019
.travis.yml Outdated
- 7.2
- 7.3
# - 7.4 // Not available yet on Travis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use 7.4snapshot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will try

@drupol
Copy link
Contributor

drupol commented Nov 29, 2019

Nice, eagerly waiting for this.

@@ -64,7 +64,7 @@ protected function configure(): void
/**
* @return int|void
*/
public function execute(InputInterface $input, OutputInterface $output)
public function execute(InputInterface $input, OutputInterface $output): int
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@veewee veewee merged commit 122571d into phpro:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants