Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass array of directories to phpcpd #697

Merged
merged 1 commit into from Nov 8, 2019
Merged

Pass array of directories to phpcpd #697

merged 1 commit into from Nov 8, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 7, 2019

Q A
Branch support-phpcs-multiple-dirs
Bug fix? yes/no
New feature? yes/no
BC breaks? yes/no
Deprecations? yes/no
Documented? yes/no
Fixed tickets #696

Phpcpd allows users to pass multiple directories to the command. The tool will then check for duplicated code in those directories.

Grumphp doesn't take advantage of this - instead, users can only pass a single string for the directory.

This PR changes the string into an array, and updates the processing and docs accordingly.

@veewee veewee added this to the 0.16.3 milestone Nov 8, 2019
@veewee
Copy link
Contributor

veewee commented Nov 8, 2019

Looks good. Thanks for the PR!

@veewee veewee merged commit e60cb1e into phpro:master Nov 8, 2019
@veewee veewee modified the milestones: 0.17.1, 0.17.0 Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant