Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust the gitignore so the bin directory gets included in the repo #681

Merged
merged 1 commit into from
Sep 22, 2019

Conversation

pjonckiere
Copy link
Contributor

Q A
Branch master
Bug fix? yes (?)
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets none

Because of the .gitignore in this project, we cannot commit the executable for grumphp to our repository. We would like to do that, but afaik there is no way to overrule that without changing the .gitignore file itself. This PR does exactly that.

Note that not committing our vendor directory is currently not an option.

@veewee
Copy link
Contributor

veewee commented Sep 20, 2019

Hello @pjonckiere,

Thanks for reporting.

Since the gitignore whitelists the grumphp exectuable, you should be able to commit it right?

I don't understand what problem you are trying to solve with this PR. Can you give me some more details about what you are trying to achieve?

@pjonckiere
Copy link
Contributor Author

Hi @veewee ,

My goal is to get the bin/grumphp file commited to our repo.

The whitelisting behaviour is what I was expecting as well, however the git docs say:

It is not possible to re-include a file if a parent directory of that file is excluded.

That's why I think this change is needed before we can add the file to our repo.

@veewee veewee added this to the 0.16.1 milestone Sep 22, 2019
@veewee
Copy link
Contributor

veewee commented Sep 22, 2019

Thanks @pjonckiere,

Since it's just an old relic, it makes sense to remove it.

@veewee veewee merged commit 6ac2ae8 into phpro:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants