Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exectuable locator #679

Merged
merged 1 commit into from
Sep 22, 2019
Merged

Improve exectuable locator #679

merged 1 commit into from
Sep 22, 2019

Conversation

veewee
Copy link
Contributor

@veewee veewee commented Sep 17, 2019

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets #671, #677

This PR:

  • Moves bin-dir prepending to PATH outside the ComposerFile logic and runs it when loading the Symfony exectuable finder. This fixes a possible issue when a bin dir is defined with env variables that is different from the one in composer.
  • Adds documentation on how to support multiple bin dirs.
  • Adds .phar as a valid suffix so that those executables can also be detected.

@veewee veewee added this to the 0.16.1 milestone Sep 17, 2019
@veewee veewee force-pushed the improve-executable-locator branch from 36de1d5 to b3678b4 Compare September 18, 2019 04:33
@veewee veewee merged commit 9906305 into phpro:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.16.1
Development

Successfully merging this pull request may close these issues.
1 participant
@veewee