Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory_limit type. #670

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Fix memory_limit type. #670

merged 1 commit into from
Sep 9, 2019

Conversation

ticdenis
Copy link
Contributor

@ticdenis ticdenis commented Sep 5, 2019

memory_limit must be null or string.

Q A
Branch master for features and deprecations
Bug fix? yes/no
New feature? yes/no
BC breaks? yes/no
Deprecations? yes/no
Documented? yes/no
Fixed tickets comma-separated list of tickets fixed by the PR, if any

New Task Checklist:

  • Is the README.md file updated?
  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpspec tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

`memory_limit` must be `null` or `string`.
@veewee veewee added this to the 0.16.0 milestone Sep 9, 2019
@veewee
Copy link
Contributor

veewee commented Sep 9, 2019

Thanks @ticdenis

@veewee veewee merged commit 0ee6fb2 into phpro:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants