Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/monolog 2 #666

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Feature/monolog 2 #666

merged 2 commits into from
Sep 9, 2019

Conversation

pimjansen
Copy link
Contributor

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets n/a

The PR adds support for Monolog ^2.0

New Task Checklist:

  • Is the README.md file updated?
  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpspec tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

@pimjansen
Copy link
Contributor Author

No idea why the builds are failing actually since it seems more like an CI implementation thing?

@TomPradat
Copy link

I think you should not change the indentation of the composer.json file.

Can someone look into the CI which seems broken indeed ?

@veewee
Copy link
Contributor

veewee commented Sep 4, 2019

CI is fixed in #644, but I am waiting for a review before I can merge it in. Should have fixed it in a separate PR. The changeset is indeed rather big for one composer version constraint.

@pimjansen
Copy link
Contributor Author

@veewee i updated the file. Updated it default to 2 tab indent instead of 4 what it was.

@veewee
Copy link
Contributor

veewee commented Sep 5, 2019

Thanks for the effort! Will merge it soon.

@veewee veewee added this to the 0.16.0 milestone Sep 5, 2019
@veewee veewee merged commit e78281a into phpro:master Sep 9, 2019
@pimjansen
Copy link
Contributor Author

Thanks 👌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants