Upgrade to php 7.1 #616
Merged
Upgrade to php 7.1 #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Landerstraeten
force-pushed
the
line-nazareth-gent-oostakker
branch
2 times, most recently
from
ad8fab1 to
66b9c87
Compare
SerkanYildiz
suggested changes
Apr 19, 2019
| * @param string|null $value | ||
| */ | ||
| public function addOptionalArgument(string $argument, $value) | ||
| public function addOptionalArgument(string $argument, $value = null): void |
There was a problem hiding this comment.
Suggested change
| public function addOptionalArgument(string $argument, $value = null): void | |
| public function addOptionalArgument(string $argument, string $value = null): void |
There was a problem hiding this comment.
@SerkanYildiz $value can also be null or an integer
There was a problem hiding this comment.
Ok, according to the removed php docblock it should be an string|null, that's why it was my suggested change :)
Landerstraeten
force-pushed
the
line-nazareth-gent-oostakker
branch
4 times, most recently
from
d749027 to
2c0bd02
Compare
Landerstraeten
force-pushed
the
line-nazareth-gent-oostakker
branch
from
2c0bd02 to
d0dcdca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.