Allow to filter with a regex pattern with the addition of whitelist pattern option to Yaml Lint task #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Landerstraeten
suggested changes
Jul 27, 2018
src/Task/YamlLint.php
Outdated
| $files = $context->getFiles()->name('/\.(yaml|yml)$/i'); | ||
| /** @var array $config */ | ||
| $config = $this->getConfiguration(); | ||
| $whitelistPatterns = isset($config['whitelist_patterns']) ? $config['whitelist_patterns'] : []; |
There was a problem hiding this comment.
$whitelistPatterns = $config['whitelist_patterns'];isset check is done in getConfigurableOptions()
There was a problem hiding this comment.
Hi, thanks for the reply.
I've deleted the isset check on $whitelistPatterns
src/Task/YamlLint.php
Outdated
| /** @var array $config */ | ||
| $config = $this->getConfiguration(); | ||
| $whitelistPatterns = isset($config['whitelist_patterns']) ? $config['whitelist_patterns'] : []; | ||
| $extensionPattern = '/\.(yaml|yml)$/i'; |
There was a problem hiding this comment.
In most tasks, this variable is named $extensions (for consistency)
There was a problem hiding this comment.
The variable name has been changed : $extensionPattern -> $extensions
…name variable for the code consistency
|
Hi, Requested changes have been done. Could you check the pull request again ? Thanks 😃 |
Landerstraeten
approved these changes
Aug 2, 2018
|
Hi @DidYoun, Thanks for the PR! The changes look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for PRs :
This PR add a new whitelist_patternsoption to Yamllint task. It will be used to filter files to be validated.
Example for a Symfony, validate PHP files only in src/ directory
New Task Checklist:
run()method readable?run()method using the configuration correctly?