Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpunit suite #303

Merged
merged 4 commits into from
Feb 24, 2017
Merged

Phpunit suite #303

merged 4 commits into from
Feb 24, 2017

Conversation

cdekok
Copy link
Contributor

@cdekok cdekok commented Feb 20, 2017

Q A
Branch master for features and deprecations
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets #297

Add a testsuite option to the phpunit task

@cdekok
Copy link
Contributor Author

cdekok commented Feb 20, 2017

it looks like appveyor is failing on something called Chocolatey seems to be their problem.

@veewee
Copy link
Contributor

veewee commented Feb 20, 2017

Thanks for the PR! Yes, I've also noticed it. I'll try to take a look at it at the end of the week. The code looks good, one small remark: why not use testsuite as property name? This way it has the same naming as in phpunit.

@cdekok
Copy link
Contributor Author

cdekok commented Feb 20, 2017

You are right there was not really a reason only i liked it better with group ;) but better to keep the same name convention as the phpunit parameters

@veewee veewee added this to the Version 0.11.3 milestone Feb 24, 2017
@veewee veewee merged commit 7ca6d0a into phpro:master Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants