Triggered by option for phpcsfixer2 task #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
reviewed
Feb 10, 2017
| @@ -84,3 +85,9 @@ Show applied fixers. | |||
| *Default: false* | |||
|
|
|||
| Show the full diff that will be applied. | |||
|
|
|||
There was a problem hiding this comment.
There should be 2 new lines before the option.
|
|
||
| *Default: [php]* | ||
|
|
||
| This option will specify which file extensions will trigger the phpcsfixer2 task. |
There was a problem hiding this comment.
There should be a newline at the end of the file.
| @@ -35,6 +35,7 @@ public function getConfigurableOptions() | |||
| 'path_mode' => null, | |||
| 'verbose' => true, | |||
| 'diff' => false, | |||
| 'triggered_by' => ['php'], | |||
There was a problem hiding this comment.
Can you also add this option to the spec test?
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "triggered_by" option to the phpcsfixer2 task as described in #284.