Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added kahlan support #236

Merged
merged 3 commits into from
Dec 5, 2016
Merged

Added kahlan support #236

merged 3 commits into from
Dec 5, 2016

Conversation

Grafikart
Copy link
Contributor

@Grafikart Grafikart commented Dec 5, 2016 •
edited by veewee
Loading

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? yes
Fixed tickets #225

Added support for Kahlan.

New Task Checklist:

  • Is the README.md file updated?
  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpspec tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

Grafikart
Grafikart commented Dec 5, 2016
View reviewed changes
doc/tasks/kahlan.md
istanbul: ~
lcov: ~
ff: ~
'no-colors': ~
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure on this syntax still

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other tasks we use the underscore instead so that we do not need quotes.

veewee
veewee requested changes Dec 5, 2016
View reviewed changes
Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Currently you are not using the configuration options. You can use the arguments collection to add them based on the configuration.

doc/tasks/kahlan.md
istanbul: ~
lcov: ~
ff: ~
'no-colors': ~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other tasks we use the underscore instead so that we do not need quotes.

src/GrumPHP/Task/Kahlan.php
$arguments->add('--no-interaction');

$process = $this->processBuilder->buildProcess($arguments);
$process->run();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not using the configured values at the moment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to add option automatically or do I have to use "addOptionalArgument" for every option ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently you'll have to use addOptionalArgument for every option.
However, you could create an additional method for this on the arguments collection.

src/GrumPHP/Task/Kahlan.php
$resolver->addAllowedTypes('istanbul', ['null', 'string']);
$resolver->addAllowedTypes('lcov', ['null', 'string']);
$resolver->addAllowedTypes('ff', ['null', 'int']);
$resolver->addAllowedTypes('ff', ['null', 'int']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ff option is duplicated.

veewee
veewee reviewed Dec 5, 2016
View reviewed changes
doc/tasks/kahlan.md
autoclear: ~
```

Every options available are documented on [kahlan](https://kahlan.github.io/docs/cli-options.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more information about the options in this document?
In the other tasks, we describe every possible option.
We would like to keep the documentation in the same format as the other tasks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor Author

@Grafikart Grafikart Dec 5, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this review stays visible I fixed the problem :(

@Grafikart
Copy link
Contributor Author

Fixed everything ,)

@veewee veewee added this to the Version 0.10.2 milestone Dec 5, 2016
@veewee
Copy link
Contributor

veewee commented Dec 5, 2016

That looks great! Thanks for your work!

@veewee veewee merged commit 759fd74 into phpro:master Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veewee veewee veewee approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
Version 0.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Grafikart @veewee