Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #413 - Adding guard checks before checking keyword #414

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

iifawzi
Copy link
Contributor

@iifawzi iifawzi commented Jan 19, 2023

Hi, this's fixing #413

fixes #413

Signed-off-by: Fawzi Abdulfattah [email protected]

@iifawzi iifawzi changed the title Adding guard checks before checking keyword Fix #413 - Adding guard checks before checking keyword Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 97.25% // Head: 97.25% // No change to project coverage 👍

Coverage data is based on head (80b39d9) compared to base (e6320e9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #414   +/-   ##
=========================================
  Coverage     97.25%   97.25%           
- Complexity     2194     2196    +2     
=========================================
  Files            68       68           
  Lines          5057     5057           
=========================================
  Hits           4918     4918           
  Misses          139      139           
Impacted Files Coverage Δ
src/Parser.php 100.00% <100.00%> (ø)
src/Components/AlterOperation.php 100.00% <0.00%> (ø)
src/Statements/CreateStatement.php 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that was incredibly fast!

@williamdes williamdes self-assigned this Jan 19, 2023
@williamdes williamdes added this to the 5.7.0 milestone Jan 19, 2023
@williamdes williamdes merged commit e743f9b into phpmyadmin:master Jan 19, 2023
williamdes added a commit that referenced this pull request Jan 19, 2023
Pull-request: #414

Signed-off-by: William Desportes <[email protected]>
@williamdes
Copy link
Member

phpstan had found it 👻 😄

@iifawzi
Copy link
Contributor Author

iifawzi commented Jan 19, 2023

Hahaha, yes, we should have checked that

@iifawzi
Copy link
Contributor Author

iifawzi commented Jan 19, 2023

@williamdes , I've added iifawzi@0cfa6a1, can you manage to get this merged? or should I create another PR?

Added the tests to the provider, I've missed that. and renamed them to follow our namings way

@williamdes
Copy link
Member

@williamdes , I've added iifawzi@0cfa6a1, can you manage to get this merged? or should I create another PR?

Added the tests to the provider, I've missed that. and renamed them to follow our namings way

I pushed it as 1a5b97c 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notice in ./vendor/phpmyadmin/sql-parser/src/Parser.php#483
2 participants