Allowing the NOT keyword as an expression
#391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iifawzi
force-pushed
the
fixing-not-option
branch
from
43eab7d
to
c2439e4
Compare
Codecov ReportBase: 95.60% // Head: 95.60% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
=========================================
Coverage 95.60% 95.60%
- Complexity 2173 2174 +1
=========================================
Files 68 68
Lines 4616 4617 +1
=========================================
+ Hits 4413 4414 +1
Misses 203 203
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: iifawzi <[email protected]>
iifawzi
force-pushed
the
fixing-not-option
branch
from
c2439e4
to
392686d
Compare
iifawzi
changed the title
NOT option as an expressionNOT keyword as an expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iifawzi [email protected]
Hi, This PR is following up on #388 and reverting its changes.
Fixing #374 (comment).
Tests have been updated. This should have been the accurate fix from the first place :')