Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the additional body tokens issue when create view statements #371

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

iifawzi
Copy link
Contributor

@iifawzi iifawzi commented Feb 3, 2022

Fixing phpmyadmin/phpmyadmin#17321
Signed-off-by: Fawzi E. Abdulfattah [email protected]

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #371 (471ba6a) into master (0deffe5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #371      +/-   ##
============================================
+ Coverage     95.57%   95.60%   +0.02%     
  Complexity     2092     2092              
============================================
  Files            67       67              
  Lines          4477     4478       +1     
============================================
+ Hits           4279     4281       +2     
+ Misses          198      197       -1     
Impacted Files Coverage Δ
src/Statements/CreateStatement.php 100.00% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0deffe5...471ba6a. Read the comment docs.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, you rock 🚀 !

@williamdes williamdes self-assigned this Feb 3, 2022
@williamdes williamdes added this to the 5.6.0 milestone Feb 3, 2022
williamdes added a commit that referenced this pull request Feb 28, 2022
Signed-off-by: William Desportes <[email protected]>
@williamdes williamdes merged commit e5cb8a1 into phpmyadmin:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants